From b114e4f963003e490530af1de94a7e15384d930a Mon Sep 17 00:00:00 2001
From: Bill Erickson <berick@esilibrary.com>
Date: Fri, 20 Dec 2013 11:12:30 -0500
Subject: [PATCH] LP#1268636 HTML table attributes validation repairs

Replace old-school inline cellpadding, cellspacing, border attributes
with CSS.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
---
 Open-ILS/src/templates/opac/css/style.css.tt2            | 14 ++++++++++++++
 Open-ILS/src/templates/opac/myopac/circs.tt2             |  2 +-
 Open-ILS/src/templates/opac/myopac/holds.tt2             |  4 ++--
 Open-ILS/src/templates/opac/myopac/lists.tt2             |  4 ++--
 Open-ILS/src/templates/opac/myopac/main_payment_form.tt2 |  2 +-
 Open-ILS/src/templates/opac/parts/anon_list.tt2          |  2 +-
 Open-ILS/src/templates/opac/parts/record/copy_table.tt2  |  2 +-
 Open-ILS/src/templates/opac/parts/result/table.tt2       |  7 +++----
 8 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/Open-ILS/src/templates/opac/css/style.css.tt2 b/Open-ILS/src/templates/opac/css/style.css.tt2
index 1076338243..5716495c69 100644
--- a/Open-ILS/src/templates/opac/css/style.css.tt2
+++ b/Open-ILS/src/templates/opac/css/style.css.tt2
@@ -689,6 +689,20 @@ collapse correctly when the window width decreases */
     color:[% css_colors.primary_fade %];
 }
 
+.table_no_border_space {
+  border-spacing: 0px;
+}
+.table_no_cell_pad td {
+  padding: 0px;
+}
+.table_no_border {
+  border-collapse: collapse;
+}
+
+#result_table_table {
+  margin-top:10px;
+}
+
 #result_table_div {
     margin-top: 1em;
 }
diff --git a/Open-ILS/src/templates/opac/myopac/circs.tt2 b/Open-ILS/src/templates/opac/myopac/circs.tt2
index 21d4baafb8..8d856e1411 100644
--- a/Open-ILS/src/templates/opac/myopac/circs.tt2
+++ b/Open-ILS/src/templates/opac/myopac/circs.tt2
@@ -33,7 +33,7 @@
     <div id='checked_main'>
         <form method="post" id="circ-form"
             onsubmit="return confirm('[% l("Are you sure you wish to renew the selected item(s)?") %]');">
-        <table cellpadding='0' cellspacing='0' class="item_list_padding">
+        <table class="table_no_border_space table_no_cell_pad item_list_padding">
             <tr>
                 <td>
                     <select name="action">
diff --git a/Open-ILS/src/templates/opac/myopac/holds.tt2 b/Open-ILS/src/templates/opac/myopac/holds.tt2
index 18eadc2fe4..e8ecea93d1 100644
--- a/Open-ILS/src/templates/opac/myopac/holds.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds.tt2
@@ -53,7 +53,7 @@
     <div class="clear-both"></div>
     <div id='holds_main'>
         <form method="post">
-        <table cellpadding='0' cellspacing='0' class="opac-auto-097">
+        <table class="table_no_border_space table_no_cell_pad" class="opac-auto-097">
             <tr>
                 <td width="1">
                     <select name="action" id="acct_holds_actions" aria-label="[%
@@ -107,7 +107,7 @@
         <div class="hide_me">
             <select id="hold_pickup_lib_temp" name="hold_pickup_lib_sel" class="hide_me"></select>
         </div>
-        <table id="acct_holds_main_header" cellpadding='0' cellspacing='0' border='0'>
+        <table id="acct_holds_main_header" class="table_no_border_space table_no_cell_pad">
             <thead>
             <tr>
                 <th align="center">
diff --git a/Open-ILS/src/templates/opac/myopac/lists.tt2 b/Open-ILS/src/templates/opac/myopac/lists.tt2
index ccfafb15a4..36adee2b0c 100644
--- a/Open-ILS/src/templates/opac/myopac/lists.tt2
+++ b/Open-ILS/src/templates/opac/myopac/lists.tt2
@@ -11,7 +11,7 @@
     <!-- new list creation -->
     <form action="[% mkurl(ctx.opac_root _ '/myopac/list/update') %]" method="post" id="create_form">
         <h1>[% l('Create New List') %]</h1><a name="createnewlist"></a>
-        <table cellpadding="0" border="0" id="list_create_table">
+        <table class="table_no_cell_pad" id="list_create_table">
             <tr>
                 <td>
                     <label for="list_create_name">[% l('Enter the name of the new list:') %]</label>
@@ -274,7 +274,7 @@
         <form action="[% mkurl(ctx.opac_root _ '/myopac/list/update') %]" method="post">
         <input type="hidden" name="list" value="[% bbag.id %]" />
         <input type="hidden" name="sort" value="[% CGI.param('sort') | uri %]" />
-        <table class="bookbag-specific" cellpadding='0' cellspacing='0' border='0'>
+        <table class="bookbag-specific table_no_cell_pad table_no_border_space table_no_border">
             <thead id="acct_list_header">
                 <tr>
                     <td class="list_checkbox">
diff --git a/Open-ILS/src/templates/opac/myopac/main_payment_form.tt2 b/Open-ILS/src/templates/opac/myopac/main_payment_form.tt2
index 8da0287e85..93ac28348c 100644
--- a/Open-ILS/src/templates/opac/myopac/main_payment_form.tt2
+++ b/Open-ILS/src/templates/opac/myopac/main_payment_form.tt2
@@ -40,7 +40,7 @@
                     <td colspan='2'><strong>[% l('Billing Information') %]</strong></td>
                     <td rowspan='13' valign='top'>
                         <p>[% l('Selected fines you are paying for:') %]</p>
-                        <table cellpadding="0" cellspacing="0" border="0" class="myopac_payments_table">
+                        <table class="table_no_border_space table_no_cell_pad" class="myopac_payments_table">
                             <thead>
                                 <tr>
                                     <th>[% l('Name') %]</th>
diff --git a/Open-ILS/src/templates/opac/parts/anon_list.tt2 b/Open-ILS/src/templates/opac/parts/anon_list.tt2
index 252f4ae05a..47e496f6ca 100644
--- a/Open-ILS/src/templates/opac/parts/anon_list.tt2
+++ b/Open-ILS/src/templates/opac/parts/anon_list.tt2
@@ -14,7 +14,7 @@
         <form action="[% mkurl(ctx.opac_root _ '/mylist/move') %]" method="get">
         <div>
             <p class="big-strong">[% l('Temporary List') %]</p>
-            <table cellpadding='0' cellspacing='0' border='0'>
+            <table class="table_no_border_space table_no_cell_pad table_no_border">
                 <thead id="acct_list_header_anon">
                     <tr>
                         <td width="1%" style="padding-left:10px;">
diff --git a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2
index a19421885a..f6ec522bdc 100644
--- a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2
+++ b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2
@@ -26,7 +26,7 @@ FOREACH copy_info IN copies;
 END;
 -%]
 [%- IF has_copies; %]
-<table cellpadding="0" cellspacing="0" border="0" width="100%" id="rdetails_status">
+<table class="table_no_border_space table_no_cell_pad table_no_border" width="100%" id="rdetails_status">
     <thead>
         <tr>
             [% IF serial_holdings -%]
diff --git a/Open-ILS/src/templates/opac/parts/result/table.tt2 b/Open-ILS/src/templates/opac/parts/result/table.tt2
index 3d77b9098b..06a7c69436 100644
--- a/Open-ILS/src/templates/opac/parts/result/table.tt2
+++ b/Open-ILS/src/templates/opac/parts/result/table.tt2
@@ -25,8 +25,8 @@
     [% INCLUDE 'opac/parts/result/facets.tt2' %]
     </div>
             <div id="result_block" class="result_block_visible">
-                <table cellpadding="0" cellspacing="0"
-                    border="0" style="margin-top:10px;">
+                <table id="result_table_table"
+                  class="table_no_border_space table_no_cell_pad">
                     <tbody id="result_table">
                     [%  FOR rec IN ctx.records;
                             attrs = {marc_xml => rec.marc_xml};
@@ -110,8 +110,7 @@ END;
                                                             class='classic_link hide_me'
                                                             name="googleBooks-link">[% l("Browse in Google Books Search") %]</a>
                                                     </span>
-                                                    <table cellpadding="0" cellspacing="0" border="0"
-                                                        class="results_info_table">
+                                                    <table class="table_no_border_space table_no_cell_pad table_no_border results_info_table">
                                                         [% IF args.holdings.size > 0 %]
                                                         <tr name='bib_cn_list' class='result_table_title_cell'>
                                                             <td valign='top'>
-- 
2.11.0