From b1e21e997260fd631423424264a9b8b4dc5bf510 Mon Sep 17 00:00:00 2001
From: djfiander <djfiander>
Date: Fri, 23 Jun 2006 02:32:24 +0000
Subject: [PATCH] FID_PATRON_PWD is a valid field in a "Renew All" message. 
 Also fix handling of failure status returned from ILS::renew_all.

---
 Sip/MsgType.pm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/Sip/MsgType.pm b/Sip/MsgType.pm
index 1200075..ec29ea8 100644
--- a/Sip/MsgType.pm
+++ b/Sip/MsgType.pm
@@ -257,7 +257,8 @@ my %handlers = (
 			    template => "A18",
 			    template_len => 18,
 			    fields => [(FID_INST_ID), (FID_PATRON_ID),
-				       (FID_TERMINAL_PWD), (FID_FEE_ACK)],
+				       (FID_PATRON_PWD), (FID_TERMINAL_PWD),
+				       (FID_FEE_ACK)],
 			}
 		    }
 		}
@@ -1363,10 +1364,19 @@ sub handle_renew_all {
     $status = $ils->renew_all($patron_id, $patron_pwd, $fee_ack);
 
     $resp .= $status->ok ? '1' : '0';
-    @renewed = @{$status->renewed};
-    @unrenewed = @{$status->unrenewed};
-    $resp .= add_count("renew_all/renewed_count", scalar @renewed);
-    $resp .= add_count("renew_all/unrenewed_count", scalar @unrenewed);
+
+    if (!$status->ok) {
+	$resp .= add_count("renew_all/renewed_count", 0);
+	$resp .= add_count("renew_all/unrenewed_count", 0);
+	@renewed = [];
+	@unrenewed = [];
+    } else {
+	@renewed = @{$status->renewed};
+	@unrenewed = @{$status->unrenewed};
+	$resp .= add_count("renew_all/renewed_count", scalar @renewed);
+	$resp .= add_count("renew_all/unrenewed_count", scalar @unrenewed);
+    }
+
     $resp .= Sip::timestamp;
     $resp .= add_field(FID_INST_ID, $ils->institution);
 
-- 
2.11.0