From b24c71c0902b17b8137e57df6f4512e9698163b3 Mon Sep 17 00:00:00 2001
From: Stephanie Leary <stephanie.leary@equinoxoli.org>
Date: Thu, 9 Mar 2023 16:08:40 +0000
Subject: [PATCH] LP2009865 Heading tags for catalog search results

Alters the markup of the search results list to use <h3> for the title
and <h4> for the author. To keep the heading outline in the correct
order, this also changes the "Search Results (N)" heading from <h3> to
<h2>.

In conjunction with the fix for Bug #1994711, this produces the
following page outline:

h1. Staff Catalog
h2. Search Results (N)
(repeat for each result:)
h3. [Title]
h4. [Author]
(repeat for each facet box:)
h4. [Facet title]

The facet headings should probably be adjusted separately.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
---
 .../eg2/src/app/staff/catalog/result/record.component.css    | 12 ++++++++++++
 .../eg2/src/app/staff/catalog/result/record.component.html   |  7 ++++++-
 .../eg2/src/app/staff/catalog/result/results.component.css   |  5 +++++
 .../eg2/src/app/staff/catalog/result/results.component.html  |  2 +-
 .../eg2/src/app/staff/catalog/result/results.component.ts    |  3 ++-
 5 files changed, 26 insertions(+), 3 deletions(-)
 create mode 100644 Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.css

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.css b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.css
index 2930138605..a52a391bc2 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.css
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.css
@@ -13,3 +13,15 @@
     max-height: 158px;
     max-width: 100px;
 }
+
+h3.bib-field-title {
+    font-size: .88rem;
+    font-weight: bold;
+    margin: 0;
+}
+
+h4.bib-field-author {
+    font-size: .88rem;
+    font-weight: normal;
+    margin: 0;
+}
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html
index fa33c54aa3..1ea6a97ec5 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html
@@ -38,7 +38,8 @@
         </ng-container>
         <div class="flex-1 pl-2">
           <div class="row">
-            <div class="col-lg-12 font-weight-bold">
+            <div class="col-lg-12">
+              <h3 class="bib-field-title">
               <ng-container *ngIf="hasMrConstituentRecords(summary)">
                   <a routerLink="/staff/catalog/search"
                     [queryParams]="appendFromMrParam(summary)">
@@ -46,6 +47,7 @@
                       [usePlaceholder]="true"></eg-bib-display-field>
                   </a>
               </ng-container>
+              
               <ng-container *ngIf="!hasMrConstituentRecords(summary)">
                 <a routerLink="/staff/catalog/record/{{summary.id}}"
                   [queryParams]="currentParams()">
@@ -53,15 +55,18 @@
                     [usePlaceholder]="true"></eg-bib-display-field>
                 </a>
               </ng-container>
+              </h3>
             </div>
           </div>
           <div class="row pt-2">
             <div class="col-lg-12">
+              <h4 class="bib-field-author">
               <a routerLink="/staff/catalog/search"
                 [queryParams]="getAuthorSearchParams(summary)">
                 <eg-bib-display-field [summary]="summary" field="author"
                   [usePlaceholder]="true"></eg-bib-display-field>
               </a>
+              </h4>
             </div>
           </div>
           <div class="row pt-2">
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.css b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.css
new file mode 100644
index 0000000000..276fd94457
--- /dev/null
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.css
@@ -0,0 +1,5 @@
+#staff-catalog-results-container h2 {
+    color: #212529;
+    font-size: 1.15rem;
+    font-weight: 500;
+}
\ No newline at end of file
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.html
index 5f584a52da..58a6eeb4ad 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.html
@@ -38,7 +38,7 @@
   <div class="row">
     <div class="col-lg-2" *ngIf="!searchContext.basket">
       <ng-container *ngIf="!searchContext.termSearch.browseEntry">
-        <h3 i18n>Search Results ({{searchContext.result.count}})</h3>
+        <h2 i18n>Search Results ({{searchContext.result.count}})</h2>
       </ng-container>
     </div>
     <div class="col-lg-2" *ngIf="searchContext.basket">
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.ts
index f4e42c1073..76711e1ebd 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/results.component.ts
@@ -14,7 +14,8 @@ import {ServerStoreService} from '@eg/core/server-store.service';
 
 @Component({
   selector: 'eg-catalog-results',
-  templateUrl: 'results.component.html'
+  templateUrl: 'results.component.html',
+  styleUrls: ['results.component.css']
 })
 export class ResultsComponent implements OnInit, OnDestroy {
 
-- 
2.11.0