From b303827e58fe04aac8f491af54cf7d8fbf6e3d8e Mon Sep 17 00:00:00 2001 From: Dan Wells Date: Tue, 9 Feb 2016 10:22:46 -0500 Subject: [PATCH] LP#1526547 Re-broaden backdate note setting The previous commit missed a case where we still want the backdate message to appear. Let's recentralize it, but at a different level. Signed-off-by: Dan Wells Signed-off-by: Kathy Lussier --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm | 2 +- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm index 5e256b15e9..3e438ce69c 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm @@ -604,7 +604,7 @@ sub post_checkin_backdate_circ_impl { $e->update_action_circulation($circ) or return $e->die_event; # now void the overdues "erased" by the back-dating - my $evt = OpenILS::Application::Circ::CircCommon->void_or_zero_overdues($e, $circ, {backdate => $backdate, note => 'System: OVERDUE REVERSED FOR BACKDATE'}); + my $evt = OpenILS::Application::Circ::CircCommon->void_or_zero_overdues($e, $circ, {backdate => $backdate}); return $evt if $evt; # If the circ was closed before and the balance owned !=0, re-open the transaction diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm index f06a9ee7ca..4947a196e7 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm @@ -38,6 +38,7 @@ sub void_or_zero_overdues { if( $opts->{backdate} ) { my $backdate = $opts->{backdate}; + $opts->{note} = 'System: OVERDUE REVERSED FOR BACKDATE' if !$opts->{note}; # ------------------------------------------------------------------ # Fines for overdue materials are assessed up to, but not including, # one fine interval after the fines are applicable. Here, we add -- 2.11.0