From b7a3ce7bf0423a86e26763713442a17d6e9cac41 Mon Sep 17 00:00:00 2001 From: Dan Wells Date: Thu, 15 Aug 2019 10:20:17 -0400 Subject: [PATCH] LP#1796945 Match new path_label/alias standard The old reporter used '::' as a path separator in some labels, while the new version uses '->' in its place. This would normally be just a curiosity, except that the hashes used as join aliases are generated from these path labels. The end result is that while a report can be cloned, if you add a field anywhere other than the top level, it references a join alias which does not exist, and the report breaks. Now, the method by which report templates are upgraded from v4 to v5 does not happen all in one pass, but rather a first pass is made populate the interface, then the rest is done when the user saves the clone. Because of this, it actually seems adequate to only fix the label, then allow the other steps to fill in the other bits upon saving of the report. Thank you to J. Boyer for helping track down the culprit. Signed-off-by: Dan Wells --- Open-ILS/web/js/ui/default/staff/reporter/template/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/web/js/ui/default/staff/reporter/template/app.js b/Open-ILS/web/js/ui/default/staff/reporter/template/app.js index 71e9c48d8c..ed6b4d31aa 100644 --- a/Open-ILS/web/js/ui/default/staff/reporter/template/app.js +++ b/Open-ILS/web/js/ui/default/staff/reporter/template/app.js @@ -341,7 +341,7 @@ function($scope , $q , $routeParams , $location , $timeout , $window, egCore , transform : orig.transform, aggregate : (orig.aggregate == "undefined") ? undefined : orig.aggregate // old structure sometimes has undefined as a quoted string }, - path_label : rel.label + path_label : rel.label.replace('::', '->') }; if (col_type == 'filter_cols') { col['operator'] = { -- 2.11.0