From b7db1fd1ae0a59292cd47c2dae344e1ba585c768 Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Wed, 19 Jun 2013 16:49:14 -0400 Subject: [PATCH] Silence QP warning due to inappropriate cmp op In QueryParser, we're comparing two strings, but using the numeric != operator. Switching to the 'ne' operator silences a warning that came up 7,000 today in our logs so far... Signed-off-by: Dan Scott --- .../perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm index 4fcbe5ee74..f50ab0bebe 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm @@ -946,7 +946,7 @@ sub flatten { . ${spc} x 2 ."AND ${talias}.field IN (". join(',', @field_ids) . ")\n" . "${spc})"; - if ($join_type != 'INNER') { + if ($join_type ne 'INNER') { my $NOT = $node->negate ? '' : ' NOT'; $where .= "${talias}.id IS$NOT NULL"; } elsif ($where ne '') { -- 2.11.0