From bcdf02bdf70b6d7e432f111c2819923687bb664f Mon Sep 17 00:00:00 2001
From: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Date: Wed, 24 Aug 2022 16:58:49 -0400
Subject: [PATCH] messages on catalog in case of hold suspend failure

---
 .../eg2/src/app/staff/catalog/hold/hold.component.html |  7 +++++++
 .../eg2/src/app/staff/catalog/hold/hold.component.ts   | 18 +++++++++++-------
 2 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
index bfe8b3d410..45068f7abb 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
@@ -9,6 +9,13 @@
     Please chose a date in the future">
 </eg-alert-dialog>
 
+<eg-alert-dialog #nextHourAlert
+  i18n-dialogTitle i18n-dialogBody
+  dialogTitle="Can Not Suspend"
+  dialogBody="Hold can not be suspended because the pickup library is either open
+    or does not have hours of operation defined.">
+</eg-alert-dialog>
+
 <div class="row">
   <div class="col-lg-1">
     <button class="btn btn-info label-with-material-icon"
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts
index 85448a26c2..80d83b535b 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts
@@ -100,7 +100,8 @@ export class HoldComponent implements OnInit {
     @ViewChild('smsCbox', {static: false}) smsCbox: ComboboxComponent;
 
     @ViewChild('activeDateAlert') private activeDateAlert: AlertDialogComponent;
-
+    @ViewChild('nextHourAlert') private nextHourAlert: AlertDialogComponent;
+    
     constructor(
         private router: Router,
         private route: ActivatedRoute,
@@ -706,22 +707,25 @@ export class HoldComponent implements OnInit {
     }
 
 	nextOpenTime(){
+        this.activeDateStr = "";
 		this.net.request('open-ils.actor',
             'open-ils.actor.org_unit.next_operating_hour',this.pickupLib
         ).subscribe(
             resp => {
                 console.log(resp);
-                if(resp){
+                if(resp && typeof resp === 'string'){
                     this.activeDateSelected(resp);
                 }
-                else{
+            },
+            error => {
+                console.log(error);
+            },
+            () => {
+                if(!this.activeDateStr){
                     this.suspend = false;
                     this.suspendTilOpen = false;
+                    this.nextHourAlert.open();
                 }
-            },
-            error => {
-                this.suspend = false;
-                this.suspendTilOpen = false;                
             }
         );
 	}
-- 
2.11.0