From bd293d208eb4600f20ef4170e485480111308e49 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Tue, 7 Feb 2023 11:33:07 -0800 Subject: [PATCH] LP#1778567: don't return cached list/tree before updating The absorbList function can be used to append items to an existing cached list (and ditto for absorbTree), so we shouldn't start off by returning the cached version. Thanks to James Fournie for catching this. Signed-off-by: Jeff Davis Signed-off-by: Ruth Frasur Signed-off-by: Galen Charlton --- Open-ILS/web/js/ui/default/staff/services/env.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Open-ILS/web/js/ui/default/staff/services/env.js b/Open-ILS/web/js/ui/default/staff/services/env.js index 2d0f197474..f82ef18d6d 100644 --- a/Open-ILS/web/js/ui/default/staff/services/env.js +++ b/Open-ILS/web/js/ui/default/staff/services/env.js @@ -96,8 +96,6 @@ function($q, $window , $injector , egAuth, egPCRUD, egIDL) { * flattens the tree for absorption. */ service.absorbTree = function(tree, class_, noOffline) { - if (service[class_] && service[class_].loaded) return; - var list = []; function squash(node) { list.push(node); @@ -112,8 +110,6 @@ function($q, $window , $injector , egAuth, egPCRUD, egIDL) { /** caches the object list both as the list and an id => object map */ service.absorbList = function(list, class_, noOffline) { - if (service[class_] && service[class_].loaded) return service[class_]; - var blob; var pkey = egIDL.classes[class_].pkey; -- 2.11.0