From beee3d490a75eb778fd69342f5129059215269a6 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Fri, 23 Oct 2020 13:05:54 -0700 Subject: [PATCH] LP#1901247: skip unnecessary user/ws setting updates when the value is unchanged (AngJS) Signed-off-by: Jeff Davis --- Open-ILS/web/js/ui/default/staff/services/hatch.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Open-ILS/web/js/ui/default/staff/services/hatch.js b/Open-ILS/web/js/ui/default/staff/services/hatch.js index b7e0ff54a1..5863e6f0f3 100644 --- a/Open-ILS/web/js/ui/default/staff/services/hatch.js +++ b/Open-ILS/web/js/ui/default/staff/services/hatch.js @@ -568,6 +568,12 @@ angular.module('egCoreMod') console.warn('No server setting type exists for ' + key); return service.setBrowserItem(key, value); } + } else if (summary && summary.has_staff_setting) { + // This is a previously-retrieved server-side user/ws setting. + // Don't update the server unless the value has actually changed. + if (service.keyCache[key] && service.keyCache[key] === value) { + return $q.when(); + } } var settings = {}; -- 2.11.0