From c42074bde3b1e579dc72447c07f8953df19ba369 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Thu, 4 Feb 2016 15:16:00 -0500 Subject: [PATCH] LP#1549505: fix Perl syntax error Signed-off-by: Galen Charlton --- .../perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm | 4 ++-- .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm | 4 ++-- Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm | 2 +- Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm index 3ac53e1984..6d09728ba3 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm @@ -836,14 +836,14 @@ sub toSQL { my $badges = ''; my ($badge_filter) = $self->find_filter('badges'); if ($badge_filter && @{$badge_filter->args}) { - $badges = join (',', grep /^\d+$/ @{$badge_filter->args}); + $badges = join (',', grep /^\d+$/, @{$badge_filter->args}); } # Do we have a badge_orgs() filter? (used for calculating popularity) my $borgs = ''; my ($bo_filter) = $self->find_filter('badge_orgs'); if ($bo_filter && @{$bo_filter->args}) { - my $borgs = join (',', grep /^\d+$/ @{$bo_filter->args}); + my $borgs = join (',', grep /^\d+$/, @{$bo_filter->args}); } # Build the badge-ish WITH query diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm index f30b4d9f27..6786d4e35c 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm @@ -3160,7 +3160,7 @@ sub query_parser_fts_wrapper { if (@lg_id_list) { my @borg_list; - for my $lg ( grep { /^\d+$/ } @lg_id_list} ) { + for my $lg ( grep { /^\d+$/ } @lg_id_list ) { my $lg_obj = asset::copy_location_group->retrieve($lg); next unless $lg_obj; @@ -3187,7 +3187,7 @@ sub query_parser_fts_wrapper { $site = actor::org_unit->search( { shortname => $args{org_unit} })->next unless ($site); } - if ($site && $site->id <> $top_org->id) { + if ($site && $site->id != $top_org->id) { my ($depth_filter) = $base_plan->parse_tree->find_filter('depth'); my $depth = $depth_filter->args->[0] if ($depth_filter && $depth_filter->args->[0] =~ /^\d+$/); $depth = $args{depth} if (!defined($depth) && defined($args{depth}) && $args{depth} =~ /^\d+$/); diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm index 719fc569cc..ac3783a29c 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm @@ -69,7 +69,7 @@ sub load_record { if ($self->cgi->param('badges')) { my $badges = $self->cgi->param('badges'); $badges = $badges ? split(',', $badges) : []; - $badges = [grep { /^\d+$/ } @$badges] + $badges = [grep { /^\d+$/ } @$badges]; if (@$badges) { $self->ctx->{badge_scores} = $cstore->request( 'open-ils.cstore.direct.rating.record_badge_score.search.atomic', diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm index a6aca7d849..f34398d460 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm @@ -683,7 +683,7 @@ sub load_badges { my $badges = $self->editor->search_rating_badge( { id => { '!=' => undef } } - ]); + ); if (@$badges) { my %badge_hash = map {($_->id => $_)} @$badges; -- 2.11.0