From caaa3b98e14e2a83944f30048746e6f77b401e85 Mon Sep 17 00:00:00 2001 From: Chris Sharp Date: Tue, 31 Jan 2023 14:59:18 -0500 Subject: [PATCH] LP#2004420: check that $note is defined before using it Signed-off-by: Chris Sharp --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm index c72072c87f..3d1f9ab462 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm @@ -949,9 +949,10 @@ sub void_bills { $bill->voided('t'); $bill->voider($e->requestor->id); $bill->void_time('now'); - my $n = ($bill->note) ? sprintf("%s\n", $bill->note) : ""; - $bill->note(sprintf("$n%s", $note)); - + if ($note) { # only do this if there's a $note to add + my $n = ($bill->note) ? sprintf("%s\n", $bill->note) : ""; + $bill->note(sprintf("$n%s", $note)); + } $e->update_money_billing($bill) or return $e->die_event; my $evt = $U->check_open_xact($e, $bill->xact, $xact); return $evt if $evt; -- 2.11.0