From cb7fb21c45329fd3b4f17dc4721e7f1e28ce0aab Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Wed, 19 Jun 2013 16:49:14 -0400 Subject: [PATCH] Silence QP warning due to inappropriate cmp op In QueryParser, we're comparing two strings, but using the numeric != operator. Switching to the 'ne' operator silences a warning that came up 7,000 today in our logs so far... Signed-off-by: Dan Scott Signed-off-by: Ben Shum --- .../perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm index c41f163fe1..431e26f38b 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm @@ -947,7 +947,7 @@ sub flatten { . ${spc} x 2 ."AND ${talias}.field IN (". join(',', @field_ids) . ")\n" . "${spc})"; - if ($join_type != 'INNER') { + if ($join_type ne 'INNER') { my $NOT = $node->negate ? '' : ' NOT'; $where .= "${talias}.id IS$NOT NULL"; } elsif ($where ne '') { -- 2.11.0