From cc3a41c152991d76b25841fd8e9bcafbbe65ecbf Mon Sep 17 00:00:00 2001
From: miker <miker@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 12 Feb 2010 16:06:19 +0000
Subject: [PATCH] Addressing https://bugs.launchpad.net/evergreen/+bug/520632
-- not strictly required here, but for(;;) is better form for array access
git-svn-id: svn://svn.open-ils.org/ILS/trunk@15514 dcc99617-32d9-48b4-a31d-7c20da2025e4
---
Open-ILS/web/js/dojo/MARC/Record.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Open-ILS/web/js/dojo/MARC/Record.js b/Open-ILS/web/js/dojo/MARC/Record.js
index 9a55b887c6..3daa426628 100644
--- a/Open-ILS/web/js/dojo/MARC/Record.js
+++ b/Open-ILS/web/js/dojo/MARC/Record.js
@@ -68,10 +68,10 @@ if(!dojo._hasResource["MARC.Record"]) {
insertOrderedFields : function () {
var me = this;
- for ( var i in arguments ) {
+ for ( var i in arguments ) { // arguments is special, and for..in is correct
var f = arguments[i];
var done = false;
- for (var j in this.fields) {
+ for (var j = 0; j < this.fields.length; j++) {
if (f.tag > this.fields[j].tag) {
this.insertFieldsBefore(this.fields[j], f);
done = true;
@@ -85,7 +85,7 @@ if(!dojo._hasResource["MARC.Record"]) {
insertFieldsBefore : function (target) {
arguments.splice(0,1);
var me = this;
- for (var j in this.fields) {
+ for (var j = 0; j < this.fields.length; j++) {
if (target === this.fields[j]) {
j--;
dojo.forEach( arguments, function (f) {
@@ -99,7 +99,7 @@ if(!dojo._hasResource["MARC.Record"]) {
insertFieldsAfter : function (target) {
arguments.splice(0,1);
var me = this;
- for (var j in this.fields) {
+ for (var j = 0; j < this.fields.length; j++) {
if (target === this.fields[j]) {
dojo.forEach( arguments, function (f) {
me.fields.splice(j++,0,f);
@@ -114,7 +114,7 @@ if(!dojo._hasResource["MARC.Record"]) {
var counter = 0;
for ( var i in arguments ) {
var f = arguments[i];
- for (var j in me.fields) {
+ for (var j = 0; j < me.fields.length; j++) {
if (f === me.fields[j]) {
me.fields[j].record = null;
me.fields.splice(j,0);
--
2.11.0