From cd62cedadfb8715dae3f99159039a61e2bb3ef09 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Mon, 14 Nov 2016 17:10:35 -0500 Subject: [PATCH] LP#1640255 Avoid Firefox startup error Connect to Hatch asynchronously (via $timeout) to avoid Angular digest in-progress errors in Firefox. Notes added about FF's current lack of support for externally_connectable extensions. Signed-off-by: Bill Erickson --- Open-ILS/web/js/ui/default/staff/services/hatch.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Open-ILS/web/js/ui/default/staff/services/hatch.js b/Open-ILS/web/js/ui/default/staff/services/hatch.js index 7115ecc11f..c936ef5b4e 100644 --- a/Open-ILS/web/js/ui/default/staff/services/hatch.js +++ b/Open-ILS/web/js/ui/default/staff/services/hatch.js @@ -76,7 +76,16 @@ angular.module('egCoreMod') } else { // Hatch status unknown; attempt to connect service.messages[msg.msgid] = msg; service.pending.push(msg); - service.hatchConnect(); + // Connect to Hatch asynchronously. Othwerise, results + // in a $rootScope:inprog error in Firefox, possibly + // because hatchConnect() does not yet work in FF. + // + // Firefox does not yet support runtime.connect(..) + // from the browser to "externally_connectable" extensions. + // http://stackoverflow.com/questions/38487552/externally-connectable-and-firefox-webextensions + // http://stackoverflow.com/questions/10526995/can-a-site-invoke-a-browser-extension/10527809#10527809 + // https://bugzilla.mozilla.org/show_bug.cgi?id=1204583 + $timeout(service.hatchConnect); } return msg.deferred.promise; -- 2.11.0