From d37deffcaa05ee1a82733cb770b54b42b8e5c434 Mon Sep 17 00:00:00 2001
From: Jason Etheridge <phasefx@gmail.com>
Date: Sat, 13 May 2023 20:10:23 -0400
Subject: [PATCH] IDL selectors

Signed-off-by: Jason Etheridge <phasefx@gmail.com>
---
 Open-ILS/examples/fm_IDL.xml | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml
index 9f748ecf3c..abe96f82f4 100644
--- a/Open-ILS/examples/fm_IDL.xml
+++ b/Open-ILS/examples/fm_IDL.xml
@@ -5748,7 +5748,7 @@ SELECT  usr,
 		<fields oils_persist:primary="id" oils_persist:sequence="container.biblio_record_entry_bucket_id_seq">
 			<field name="items" oils_persist:virtual="true" reporter:datatype="link"/>
 			<field name="btype" reporter:datatype="text"/>
-			<field name="id" reporter:datatype="id" />
+			<field name="id" reporter:datatype="id" reporter:selector="id"/>
 			<field name="name" reporter:datatype="text"/>
 			<field name="description" reporter:datatype="text"/>
 			<field name="owner" reporter:datatype="link"/>
@@ -12445,6 +12445,7 @@ SELECT  usr,
 		</permacrud>
 	</class>
 
+	<!-- This is what you see in Catalog -> Link Checker -->
 	<class id="uvsa" controller="open-ils.cstore open-ils.pcrud" oils_obj:fieldmapper="url_verify::sessions_and_attempts" reporter:label="Combined URL Verify Sessions and Batches View" oils_persist:readonly="true">
 		<oils_persist:source_definition><![CDATA[
 			SELECT
@@ -12472,7 +12473,7 @@ SELECT  usr,
                 (uvs.id = uvva.session)
 		]]></oils_persist:source_definition>
 		<fields oils_persist:primary="id">
-            <field reporter:label="ID" name="id" reporter:datatype="id"/>
+            <field reporter:label="ID" name="id" reporter:datatype="id" reporter:selector="name"/>
             <field reporter:label="Session ID" name="session_id" reporter:datatype="link"/>
             <field reporter:label="Name" name="name" reporter:datatype="text" oils_obj:required="true"/>
 			<field reporter:label="Owning Library" name="owning_lib" reporter:datatype="org_unit" oils_obj:required="true"/>
@@ -12501,6 +12502,7 @@ SELECT  usr,
         </permacrud>
 	</class>
 
+	<!-- This is what gets created with Catalog -> Link Checker -> New Session -->
     <class
         id="uvs"
         controller="open-ils.cstore open-ils.pcrud"
@@ -12509,7 +12511,7 @@ SELECT  usr,
         reporter:label="URL Verification Session"
     >
         <fields oils_persist:primary="id" oils_persist:sequence="url_verify.session_id_seq">
-            <field reporter:label="Session ID" name="id" reporter:datatype="id"/>
+            <field reporter:label="Session ID" name="id" reporter:datatype="id" reporter:selector="name"/>
             <field reporter:label="Name" name="name" reporter:datatype="text" oils_obj:required="true"/>
 			<field reporter:label="Owning Library" name="owning_lib" reporter:datatype="org_unit" oils_obj:required="true"/>
             <field reporter:label="Creator" name="creator" reporter:datatype="link" oils_obj:required="true"/>
@@ -12539,6 +12541,7 @@ SELECT  usr,
 
     </class>
 
+	<!-- A biblio bucket gets populated with search results from Catalog -> Link Checker -> New Session -->
     <class id="uvsbrem" controller="open-ils.cstore open-ils.pcrud" oils_obj:fieldmapper="url_verify::session_biblio_record_entry_map" oils_persist:readonly="true" reporter:label="URL Verify Session Biblio Record Entry Map">
         <oils_persist:source_definition><![CDATA[
             SELECT
@@ -12570,6 +12573,7 @@ SELECT  usr,
         </permacrud>
     </class>
 
+	<!-- Also created with Catalog -> Link Checker -> New Session -->
     <class
         id="uvus"
         controller="open-ils.cstore open-ils.pcrud"
@@ -12578,7 +12582,7 @@ SELECT  usr,
         reporter:label="URL Verification URL Selector"
     >
         <fields oils_persist:primary="id" oils_persist:sequence="url_verify.url_selector_id_seq">
-            <field reporter:label="URL Selector ID" name="id" reporter:datatype="id"/>
+            <field reporter:label="URL Selector ID" name="id" reporter:datatype="id" reporter:selector="xpath"/>
             <field reporter:label="XPath" name="xpath" reporter:datatype="text" oils_obj:required="true"/>
 			<field reporter:label="Session" name="session" reporter:datatype="link" oils_obj:required="true"/>
             <field reporter:label="URLs" name="urls" reporter:datatype="link" oils_persist:virtual="true"/>
@@ -12608,6 +12612,7 @@ SELECT  usr,
 
     </class>
 
+	<!-- URLs extracted by URL selectors -->
     <class
         id="uvu"
         controller="open-ils.cstore open-ils.pcrud"
@@ -12616,7 +12621,7 @@ SELECT  usr,
         reporter:label="URL Verification URL"
     >
         <fields oils_persist:primary="id" oils_persist:sequence="url_verify.url_id_seq">
-            <field reporter:label="URL ID" name="id" reporter:datatype="id"/>
+            <field reporter:label="URL ID" name="id" reporter:datatype="id" reporter:selector="full_url"/>
 			<field reporter:label="Redirected From" name="redirect_from" reporter:datatype="link"/>
 			<field reporter:label="Container Item" name="item" reporter:datatype="link" oils_obj:required="true"/>
 			<field reporter:label="Session" name="session" reporter:datatype="link" oils_obj:required="true"/>
@@ -12663,6 +12668,7 @@ SELECT  usr,
 
     </class>
 
+	<!-- What we now call Batches in the UI -->
     <class
         id="uvva"
         controller="open-ils.cstore open-ils.pcrud"
@@ -12702,6 +12708,7 @@ SELECT  usr,
 
     </class>
 
+	<!-- what we now call Attempts in the UI -->
     <class
         id="uvuv"
         controller="open-ils.cstore open-ils.pcrud"
-- 
2.11.0