From d4155b5b2741005a1002e9bb6c9fbdf68a81e03f Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Wed, 19 Feb 2020 12:36:30 -0800 Subject: [PATCH] LP#1774268: handle opac.hold_notify empty string in AngJS patron editor If a patron does not want either phone or email hold notifications, their opac.hold_notify user setting will be an empty string. Let's ensure that the hold notify checkboxes remain unchecked in the patron editor when that is the case. Signed-off-by: Jeff Davis Signed-off-by: Michele Morgan Signed-off-by: Jason Boyer --- Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js index f8c5ca7106..b3a5cda829 100644 --- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js +++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js @@ -1897,6 +1897,11 @@ function($scope , $routeParams , $q , $uibModal , $window , egCore , function extract_hold_notify() { var p = $scope.patron; var notify = $scope.user_settings['opac.hold_notify']; + if (notify === '') { + $scope.hold_notify_type.phone = false; + $scope.hold_notify_type.email = false; + return; + } if (!notify) { $scope.hold_notify_type.phone = true; $scope.hold_notify_type.email = true; -- 2.11.0