From d7da42d8b75659af96dc47fce7363e85b9412fb1 Mon Sep 17 00:00:00 2001 From: Jason Boyer Date: Wed, 21 Oct 2020 16:29:25 -0400 Subject: [PATCH] LP1895660: Booking.pm, Search/Biblio.pm Argument "whatev_strings" isn't numeric in numeric eq (==) at ... A couple places that use == to compare strings. Numbers are == to each other, but strings are eq to each other. Signed-off-by: Jason Boyer Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton --- Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm | 2 +- Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm index f396de7c1e..8b48d7c38b 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm @@ -1218,7 +1218,7 @@ sub cancel_reservation { $e->xact_begin; if ( - $bresv->target_resource_type->catalog_item == "t" && + $bresv->target_resource_type->catalog_item eq "t" && $bresv->current_resource ) { $logger->info("result of no-op checkin (upon cxl bresv) is " . diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm index 3606106c07..1b85799691 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm @@ -138,7 +138,7 @@ sub record_id_to_mods_slim { my( $self, $client, $id ) = @_; return undef unless defined $id; - if(ref($id) and ref($id) == 'ARRAY') { + if(ref($id) and ref($id) eq 'ARRAY') { return _records_to_mods( @$id ); } my $mods_list = _records_to_mods( $id ); -- 2.11.0