From d88d64c5f34206193834ee56fb93987a27da879c Mon Sep 17 00:00:00 2001 From: senator Date: Fri, 17 Dec 2010 19:27:31 +0000 Subject: [PATCH] Backport r19013 from trunk Thanks to Sally Fortin for drawing attention to this bug, wherein new Holding Subfields can't be created in this interface via the staff client. Acq: Tracked down a small but subtle bug with the Holding Subfield tab of the Provider editor interface. We apparently have a global variable "name" defined somewhere which, when assigned in place of an overrideWidget for an AutoGrid thanks to some vestigial code, ultimately causes an error from within AutoFieldWidget, if you're using the staff client. That's because name is the string "browser_browser" in the staff client, but if you access this interface from Firefox, name is apparently set to some value that evaluates to false in a boolean context, because AutoFieldWidget doesn't choke on it (the comparison at line 182 of that file will return false). git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19014 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/web/js/ui/default/conify/global/acq/provider.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Open-ILS/web/js/ui/default/conify/global/acq/provider.js b/Open-ILS/web/js/ui/default/conify/global/acq/provider.js index b3abfed4d4..76c63a516f 100644 --- a/Open-ILS/web/js/ui/default/conify/global/acq/provider.js +++ b/Open-ILS/web/js/ui/default/conify/global/acq/provider.js @@ -81,7 +81,6 @@ function drawProviderSummary(child) { case 'tab-hold': phsListGrid.overrideEditWidgets.provider = new dijit.form.TextBox({disabled: 'true', value: providerId}); - phsListGrid.overrideEditWidgets.name = name; phsListGrid.resetStore(); phsListGrid.loadAll({order_by:{acqphsm : 'name'}}, {provider : providerId}); break; -- 2.11.0