From d8ab50b26f8591f5bcccefc0e7ad2d3ec07c39a9 Mon Sep 17 00:00:00 2001
From: Stephanie Leary <stephanie.leary@equinoxoli.org>
Date: Tue, 30 May 2023 14:48:56 +0000
Subject: [PATCH] LP1965985 Empty alt text for OPAC decorative images

Removes alt text from images that are decorative, including book covers
and format icons, from the OPAC and BOOPAC search results pages. Since
all of these images appear next to text equivalents that repeat the same
information, these alt attributes were redundant.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
---
 Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2 | 5 ++---
 Open-ILS/src/templates/opac/parts/result/table.tt2           | 9 ++++-----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2 b/Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2
index e361dc472b..8acc80f75d 100755
--- a/Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2
+++ b/Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2
@@ -99,7 +99,7 @@
                         </div>
                         <!--Cover Image-->
                         <div class='col-sm-2 text-center' id="result[% rec.bre_id %]">
-                            <a href="[% mkurl(record_url_path, add_parms, del_parms); %]"><img alt="[% attrs.title | html;%]"
+                            <a href="[% mkurl(record_url_path, add_parms, del_parms); %]"><img alt=""
                             id='item_jacket[% rec.bre_id %]' class='my-2 img-fluid'
                             src='[% ctx.media_prefix %]/opac/extras/ac/jacket/large/r/[% rec.bre_id | uri %]' style="max-height:150px;" /></a><br />
                         </div>
@@ -120,8 +120,7 @@
                                     <span class="mx-2">
                                         [%- IF attrs.format_label; %]
                                             [% FOR format IN attrs.all_formats %]
-                                                <img alt="[% format.label | html %]"
-                                                    src="[% format.icon %]" />
+                                                <img alt="" src="[% format.icon %]" />
                                                 [% format.label | html %]
                                             [% END %]
                                         [%- END %]
diff --git a/Open-ILS/src/templates/opac/parts/result/table.tt2 b/Open-ILS/src/templates/opac/parts/result/table.tt2
index 00577f5562..f2597c1e21 100644
--- a/Open-ILS/src/templates/opac/parts/result/table.tt2
+++ b/Open-ILS/src/templates/opac/parts/result/table.tt2
@@ -115,7 +115,7 @@
                                             </td>
                                             <td class='result_table_pic_header'>
                                                 <a href="[% mkurl(record_url_path, add_parms, del_parms); %]">
-                                                 <img alt="[% l('Book cover') %]"
+                                                 <img alt=""
                                                         name='item_jacket' class='result_table_pic' width="55"
                                                         src='[% ctx.media_prefix %]/opac/extras/ac/jacket/small/r/[% rec.bre_id | uri %]' /></a><br />
                                             </td>
@@ -185,8 +185,7 @@ END;
                                                     [%- IF attrs.format_label; %]
                                                         [% FOR format IN attrs.all_formats %]
                                                             <img title="[% format.label | html %]" 
-                                                                alt="[% format.label | html %]" 
-                                                                src="[% format.icon %]" /> 
+                                                                alt="" src="[% format.icon %]" /> 
                                                             [% format.label | html %]
                                                         [% END %]
                                                     [%- END %]
@@ -422,7 +421,7 @@ END;
                                                     [% END %]
                                                     [% IF rec.user_circulated %]
                                                     <div class="result_item_circulated">
-                                                        <img src="[% ctx.media_prefix %]/images/green_check.png[% ctx.cache_key %]" alt="[% l('Checked Out Before') %]"/>
+                                                        <img src="[% ctx.media_prefix %]/images/green_check.png[% ctx.cache_key %]" alt=""/>
                                                         <span>[% l('I have checked this item out before') %]</span>
                                                     </div>
                                                     [% END %]
@@ -529,7 +528,7 @@ END;
                                                                 href="[% ctx.ext_proto %]://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=[%- 
                                                                     ENV.OILS_CONTENT_CAFE_USER %]&amp;Password=[%-
                                                                     ENV.OILS_CONTENT_CAFE_PASS %]&amp;ItemKey=[% ident | uri %]&amp;Options=Y" rel="noopener nofollow" vocab="">
-                                                                <img src='[% ctx.media_prefix %]/images/starz.png[% ctx.cache_key %]' alt="[% l('Ratings Icon') %]"/>
+                                                                <img src='[% ctx.media_prefix %]/images/starz.png[% ctx.cache_key %]' alt=""/>
                                                                 <span class="results_reviews">[% l('Reviews &amp; More') %]</span>
                                                             </a>
                                                         </div>
-- 
2.11.0