From d8d169f3ab86bd75e3c265d64690a6fe830b7a49 Mon Sep 17 00:00:00 2001 From: Galen Charlton <gmc@equinoxinitiative.org> Date: Fri, 3 Jan 2020 10:35:56 -0500 Subject: [PATCH] LP#1858138: remove remaining uses of showLinkSelector Now that showLinkSelector is deprecated and does nothing, remove current uses of it. To test ------- [1] Apply the patch. [2] Visit Angular admin interfaces that have grids that refer to linked IDL classes, e.g., - Local Admin -> Carousels (carousel type) - Server Admin -> Weights Association (circ weights and hold weights) - Local Admin -> Item Tags (copy tag type) - Acq Admin -> EDI Accounts (provider) [3] Verify that the columns for linked fields display the appropriate selector field rather than the numeric ID. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> --- .../src/eg2/src/app/staff/admin/local/admin-carousel.component.html | 2 +- Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html | 1 - .../src/eg2/src/app/staff/share/admin-page/admin-page.component.html | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html index 64714af755..b73a969114 100644 --- a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html +++ b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html @@ -41,7 +41,7 @@ <eg-translate #translator></eg-translate> <eg-grid #grid idlClass="{{idlClass}}" [dataSource]="dataSource" - [sortable]="true" persistKey="{{persistKey}}" [showLinkSelectors]="true"> + [sortable]="true" persistKey="{{persistKey}}"> <eg-grid-toolbar-button [disabled]="!canCreate" label="New {{idlClassDef.label}}" i18n-label [action]="createNew"> </eg-grid-toolbar-button> diff --git a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html index 26da699522..d456ae08a3 100644 --- a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html +++ b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html @@ -265,7 +265,6 @@ [dataSource]="acpSource" [filterable]="true" [sortable]="true" - [showLinkSelectors]="true" [stickyHeader]="true" showFields="barcode,location,circ_lib,price,dummy_title,create_date" > diff --git a/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html b/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html index c7479d62db..00bc67a47b 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html +++ b/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html @@ -34,7 +34,7 @@ </ng-container> <eg-grid #grid idlClass="{{idlClass}}" [dataSource]="dataSource" - [sortable]="true" persistKey="{{persistKey}}" [showLinkSelectors]="true"> + [sortable]="true" persistKey="{{persistKey}}"> <eg-grid-toolbar-button [disabled]="!canCreate" label="New {{idlClassDef.label}}" i18n-label (onClick)="createNew()"> </eg-grid-toolbar-button> -- 2.11.0