From d97b28bf57f75c287fcd2712fc331f4e83d8db66 Mon Sep 17 00:00:00 2001 From: Terran McCanna Date: Thu, 22 Dec 2022 15:37:43 -0500 Subject: [PATCH] Online Account Renewal - skip over update perm map The subroutine for updating the perm map was failing and does not appear to be necessary for an update in any of my testing so far. The failure appears to be caused by confusion between permission.usr_perm_map and permission.perm_list, possibly due to the way the tables are mapped. Signed-off-by: Terran McCanna --- Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm index f808e665f2..10e0a63333 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm @@ -618,8 +618,12 @@ sub update_patron { ($new_patron, $evt) = _create_stat_maps($e, $patron, $new_patron); return $evt if $evt; - ($new_patron, $evt) = _create_perm_maps($e, $patron, $new_patron); - return $evt if $evt; + # PINES - modified this because it was breaking e-renew, could not verify that it actually + # worked anywhere because the subroutine looks like it's trying to update the wrong table - TM + if($patron->isnew()) { + ($new_patron, $evt) = _create_perm_maps($e, $patron, $new_patron); + return $evt if $evt; + } $evt = apply_invalid_addr_penalty($e, $patron); return $evt if $evt; -- 2.11.0