From e8e3a30984b6057a22f9bf155b7335b73b8c651d Mon Sep 17 00:00:00 2001 From: Stephanie Leary Date: Tue, 4 Oct 2022 15:37:23 -0500 Subject: [PATCH] LP1828468 Keyboard navigation for main navbar In the main navbar, all items except the home icon are unreachable using only a keyboard. This includes the logout/change operator menu on the far right. This is caused by the lack of an href attribute on the tags, which prevents the link from having a focus state. This patch adds tabindex="0" to the parent menu items and the submenu items that use (click) or routerLink. Submenu items are also given the ngbDropdownItem directive, which allows up/down arrow navigation within submenus. The patch does not include CSS to make the focus state prettier; a separate patch for style is forthcoming. Related: Bug #1814978 Signed-off-by: Stephanie Leary Signed-off-by: Galen Charlton --- Open-ILS/src/eg2/src/app/staff/nav.component.html | 158 +++++++++++----------- 1 file changed, 79 insertions(+), 79 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/nav.component.html b/Open-ILS/src/eg2/src/app/staff/nav.component.html index ab959cae36..a850ec314d 100644 --- a/Open-ILS/src/eg2/src/app/staff/nav.component.html +++ b/Open-ILS/src/eg2/src/app/staff/nav.component.html @@ -13,21 +13,21 @@
- + Search
- Search for Patrons - + Search for Items by Barcode - @@ -39,110 +39,110 @@
- + Circulation
- Check Out - Check In - Capture Holds - + Pull List for Hold Requests - Renew Items - Register Patron - Retrieve Last Patron - + Retrieve Recent Patrons - + Pending Patrons - + User Buckets - + Hold Groups
- + Verify Credentials - Record In-House Use - + Holds Shelf
- + Replace Barcode - Item Status - + Scan Item as Missing Pieces
- Reprint Last Receipt
- + Offline Circulation
- + directions_bus Curbside Pickup @@ -154,81 +154,81 @@
- + Cataloging
- Search the Catalog - + Search the Catalog (Traditional) - Item Status
- + Record Buckets - + Item Buckets
- + Retrieve Bib Record by ID - Retrieve Bib Record by TCN - Retrieve Last Bib Record
- + Create New MARC Record - + Import Record from Z39.50 - + MARC Batch Import/Export - + MARC Batch Edit
- + Link Checker
- + Manage Authorities - + Retrieve Authority Record by ID @@ -240,74 +240,74 @@
- + Acquisitions
- General Search
- Provider Search
- Selection Lists - New Brief Record - Patron Requests - MARC Federated Search - Load Catalog Record IDs
- Load MARC Order Records - Purchase Orders - + Create Purchase Order
- Claim-Ready Items - Invoices - Create Invoice @@ -318,31 +318,31 @@
- + Booking
- + Create Reservations - + Pull List - + Capture Resources - + Pick Up Reservations - + Return Reservations - + Manage Reservations @@ -352,11 +352,11 @@
- + Administration
- + Workstation @@ -368,38 +368,38 @@ Registered Workstations --> - + User Permission Editor - Server Administration - + Local Administration - Acquisitions Administration - + Serials Administration - Booking Administration - + Reports - + Simple Reports @@ -416,12 +416,12 @@
+ class="nav-link dropdown-toggle no-caret with-material-icon" tabindex="0"> {{currentLocale.name()}}
- @@ -432,7 +432,7 @@
- @@ -445,21 +445,21 @@ failMessage="Operator Change Failed" successMessage="Operator Change Succeeded"> - Change Operator - Restore Operator - + Logout - + About -- 2.11.0