From f07c77eb747b75a2ef5ea12121230e9a6dee34ee Mon Sep 17 00:00:00 2001
From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 25 Apr 2008 20:29:24 +0000
Subject: [PATCH] The ability to perform record merges is now controlled by a
 single permission and not individual perms on volumes/copies that may have to
 be updated as part of the merge.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_2@9451 dcc99617-32d9-48b4-a31d-7c20da2025e4
---
 Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
index 7270182d25..1f4b9de489 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
@@ -38,6 +38,10 @@ sub rgrep {
 sub merge_records {
 	my( $editor, $master, $records ) = @_;
 
+    # bib records are global objects, so no org context required.
+    return (undef, $editor->die_event) 
+        unless $editor->allowed('MERGE_BIB_RECORDS');
+
 	my $vol;
 	my $evt;
 
@@ -133,7 +137,7 @@ sub merge_records {
 				$record->deleted('f');
 				$record->editor($reqr->id);
 				$record->edit_date('now');
-				$editor->update_biblio_record_entry($record, {checkperm => 1})
+				$editor->update_biblio_record_entry($record)
 					or return $editor->die_event;
 			}
 
@@ -142,7 +146,7 @@ sub merge_records {
 			$record->deleted('t');
 			$record->editor($reqr->id);
 			$record->edit_date('now');
-			$editor->update_biblio_record_entry($record, {checkperm => 1})
+			$editor->update_biblio_record_entry($record)
 				or return $editor->die_event;
 		}
 	}
@@ -216,7 +220,6 @@ sub merge_volumes {
 		$_->deleted('t');
 		$_->editor($editor->requestor->id);
 		$_->edit_date('now');
-		return (undef,$editor->die_event) unless $editor->allowed('UPDATE_VOLUME', $_->owning_lib);
 		$editor->update_asset_call_number($_) or return (undef, $editor->die_event);
         merge_volume_holds($editor, $bigcn, $_->id);
 	}
-- 
2.11.0