From f299eb2bfedef9eab7e1655686b6044027437788 Mon Sep 17 00:00:00 2001
From: Michele Morgan <mmorgan@noblenet.org>
Date: Thu, 14 Sep 2017 11:48:31 -0400
Subject: [PATCH] LP#1692116 - Action trigger validator fix for paid Long
Overdue items
Adds a check for a NULL xact_finish to the CircIsOpen validator. The
result is that overdue notification a/t events for Long Overdue items that
have been paid for, and the transaction closed, will be invalid.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---
Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
index db909a51b1..1a53dfbc40 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
@@ -18,6 +18,7 @@ sub CircIsOpen {
my $env = shift;
return 0 if (defined($env->{target}->checkin_time));
+ return 0 if (defined($env->{target}->xact_finish));
if ($env->{params}->{min_target_age}) {
$env->{params}->{target_age_field} = 'xact_start';
--
2.11.0