From f3ad285e081b1bae0e14d328943b510bd34c9d44 Mon Sep 17 00:00:00 2001 From: Jane Sandberg Date: Tue, 30 Jul 2019 13:54:10 -0700 Subject: [PATCH] LP1607922: Receiving items on page 2 of search results Previously, if a user selected a bunch of line items on two consecutive pages of acq search results, and tried to receive items from the second page, the operation would fail. This issue was caused by Evergreen caching IDs of selected line items from page 1, but not caching the data that went along with them. To test: 1) Go to Acquisitions > General Search 2) In the Select Search Field dropdown, choose LI - State. 3) Set the state to on-order. 4) Click Search. 5) Click the check mark to select all results on the first page. 6) Click the Next button. 7) Click the check mark to select all results on the second page. 8) On the top --Actions-- menu, select Mark Selected Line Items as Received. 9) Note that the interface does nothing, and that there is a TypeError error message in the browser console. 10) Apply this commit. 11) Refresh your page completely and repeat steps 1-8. 12) Note that the items on the second page are received. Since they no longer meet the search criteria, Evergreen gives you the next page of results. For further testing, see similar test steps by John Yorio at https://bugs.launchpad.net/evergreen/+bug/1607922. Signed-off-by: Jane Sandberg Signed-off-by: Chris Sharp --- Open-ILS/web/js/ui/default/acq/common/li_table_pager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/web/js/ui/default/acq/common/li_table_pager.js b/Open-ILS/web/js/ui/default/acq/common/li_table_pager.js index de24dcba68..02e4ef0825 100644 --- a/Open-ILS/web/js/ui/default/acq/common/li_table_pager.js +++ b/Open-ILS/web/js/ui/default/acq/common/li_table_pager.js @@ -26,7 +26,7 @@ function LiTablePager() { }; this.show = function() { - this.liTable.reset(/* keep_selectors */ true); + this.liTable.reset(); this.liTable.show("list"); }; -- 2.11.0