From f46a575edf62fcf26f4f05c16c1da2df3224b4f8 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Tue, 4 Dec 2012 09:46:54 -0500 Subject: [PATCH] Avoid xact rollback on un-connected CStoreEditor session Helps to reduce "No transaction to rollback" errors in the error logs. Signed-off-by: Bill Erickson --- Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm index 23559e0ce4..a9ba65c0f3 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm @@ -287,7 +287,11 @@ sub xact_commit { # ----------------------------------------------------------------------------- sub xact_rollback { my $self = shift; - return unless $self->{session} and $self->{xact_id}; + return unless $self->{xact_id}; + unless ($self->{session} and $self->{session}->connected) { + $self->log(I, "avoiding rollback attempt on un-connected session"); + return; + } $self->log(I, "rolling back db session"); my $stat = $self->request($self->app.".transaction.rollback"); $self->log(E, "error rolling back database transaction") unless $stat; -- 2.11.0