From f66fea3ce06bcb8a8e5999809d1dc6fba67a0587 Mon Sep 17 00:00:00 2001 From: Jason Etheridge Date: Fri, 27 May 2022 12:08:26 -0400 Subject: [PATCH] making assumptions here about valid patron and valid patron password fields when querying with combinations of bad barcodes and passwords Signed-off-by: Jason Etheridge --- t/04patron_status.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/04patron_status.t b/t/04patron_status.t index 365df24..ca4ef8f 100755 --- a/t/04patron_status.t +++ b/t/04patron_status.t @@ -100,14 +100,14 @@ $test->{fields} = [ pat => qr/^$user_barcode$/, required => 1, }, { field => FID_PERSONAL_NAME, - pat => qr/^$user_fullname$/o, + pat => qr/^$/o, # FIXME: expose patron info with invalid password or not? required => 1, }, { field => FID_VALID_PATRON, - pat => qr/^Y$/, - required => 1, }, + pat => qr/^N$/, # FIXME: still exposing patron info if we provide Y here with an invalid password + required => 0, }, # optional per spec { field => FID_VALID_PATRON_PWD, pat => qr/^N$/, - required => 1, }, + required => 0, }, # optional per spec ]; push @tests, $test; -- 2.11.0