From f897c2bf0e9c2a3634869a0371d78ad0da41e332 Mon Sep 17 00:00:00 2001 From: Dan Wells Date: Wed, 17 Aug 2016 11:55:32 -0400 Subject: [PATCH] LP#1228392 Allow mapped fields to show up in reporter template builder Since inception, mapped fields have been hidden in the reporter, the logic being that showing them shows too much (in particular, a circular reference back to ourselves), and is therefore confusing. However, not showing them means we have two options: 1) Don't use those fields in the reporter. 2) Add a second, non-mapped field just for the reporter. These options both seem less than ideal, so for now, just let them show up, and let the user sort it out. Signed-off-by: Dan Wells --- Open-ILS/web/reports/xul/source-browse.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Open-ILS/web/reports/xul/source-browse.js b/Open-ILS/web/reports/xul/source-browse.js index 0442e3a7dc..79bfbd627b 100644 --- a/Open-ILS/web/reports/xul/source-browse.js +++ b/Open-ILS/web/reports/xul/source-browse.js @@ -45,7 +45,11 @@ function sourceTreeHandler (ev, dbl) { var key = link_fields[i].getAttribute('key'); var reltype = link_fields[i].getAttribute('reltype'); - if (map) continue; + // We could give up here, do something smart (TBD) or + // let the user deal with the complexity manually + // + // For now, option #3 + //if (map) continue; var pathList = []; findAncestorStack( item, 'treeitem', pathList ); -- 2.11.0