From f8a069169467b793d0cc59f7f90e20743643562a Mon Sep 17 00:00:00 2001 From: erickson Date: Wed, 3 Jan 2007 18:37:45 +0000 Subject: [PATCH] fixed list logic error in hold retrieval call git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_0@6722 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm index 828902bdc3..2774f4301f 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm @@ -1321,9 +1321,12 @@ sub do_checkin { $U->copy_status($self->copy->status)->id == OILS_COPY_STATUS_ON_HOLDS_SHELF ) { - my $hold = ($hold_transit) ? - $self->editor->retrieve_action_hold_request($hold_transit->hold) : - $U->fetch_open_hold_by_copy($self->copy->id); + my $hold; + if( $hold_transit ) { + $hold = $self->editor->retrieve_action_hold_request($hold_transit->hold); + } else { + ($hold) = $U->fetch_open_hold_by_copy($self->copy->id); + } $self->hold($hold); @@ -1667,7 +1670,7 @@ sub process_received_transit { my $hold_transit = $self->editor->retrieve_action_hold_transit_copy($transit->id); - $logger->info("ciculator: Recovering original copy status in transit: ".$transit->copy_status); + $logger->info("circulator: Recovering original copy status in transit: ".$transit->copy_status); $copy->status( $transit->copy_status ); $self->update_copy(); return if $self->bail_out; -- 2.11.0