From fac4b29ae8f6a37ef329ce42855d348703b84bf9 Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@equinoxOLI.org>
Date: Wed, 8 Dec 2021 10:56:14 -0500
Subject: [PATCH] LP#1942220: tweaks to the copies inputs

- OU selector now limited to locations where user has
  CREATE_PICKLIST or CREATE_PURCHASE_ORDER
- distribution formula combobox now sorts by name
- circ modifier combobox now supports empty click

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 Open-ILS/src/eg2/src/app/staff/acq/lineitem/copies.component.html     | 1 +
 Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copies.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copies.component.html
index 48de275a17..fb8474136b 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copies.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copies.component.html
@@ -16,6 +16,7 @@
     <span class="ml-3">
       <eg-combobox idlClass="acqdf" [idlQueryAnd]="formulaFilter" 
         [asyncSupportsEmptyTermClick]="true" [startsWith]="true"
+        [idlQuerySort]="{acqdf: 'name'}"
         #distribFormCbox domId="distrib-formula-cbox">
       </eg-combobox>
     </span>
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html
index ac56dd45d0..c30f89edfa 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html
@@ -11,6 +11,7 @@
     <eg-org-select #owningLibSelect placeholder="Owning Branch..." 
       i18n-placeholder [readOnly]="fieldIsDisabled('owning_lib')"
       [applyOrgId]="copy.owning_lib()"
+      [limitPerms]="['CREATE_PICKLIST','CREATE_PURCHASE_ORDER']"
       (onChange)="valueChange('owning_lib', $event)">
     </eg-org-select>
   </div>  
@@ -46,6 +47,7 @@
     <eg-combobox idlClass="ccm" placeholder="Circ Modifier..." i18n-placeholder
       [readOnly]="fieldIsDisabled('circ_modifier')"
       #circModSelector [entries]="circModEntries"
+      [asyncSupportsEmptyTermClick]="true"
       [selectedId]="copy.circ_modifier()"
       (onChange)="valueChange('circ_modifier', $event)">
     </eg-combobox>
-- 
2.11.0