From fd0edd64f7a49e28deb6d078159c06df1412b069 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Thu, 29 Mar 2012 09:39:46 -0400 Subject: [PATCH] GridColumnPicker avoid sorting when no settings have persisted Avoid sorting cells whose _sort value is null/undefined, which can happen when no column settings have been persisted for the grid. Signed-off-by: Bill Erickson --- Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js b/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js index fe226942cd..15771629a6 100644 --- a/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js +++ b/Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js @@ -257,7 +257,7 @@ if(!dojo._hasResource["openils.widget.GridColumnPicker"]) { // extract cells that have sorting applied, order lowest to highest buildSortList : function() { var sortList = this.cells.filter( - function(cella) { return cella._sort != 0 } + function(cella) { return Number(cella._sort) } ).sort( function(a, b) { if (Math.abs(a._sort) < Math.abs(b._sort)) return -1; -- 2.11.0