From baa375d03465a7f01cedf1e18c578755de72929f Mon Sep 17 00:00:00 2001 From: Lebbeous Fogle-Weekley Date: Wed, 18 Sep 2013 13:50:51 -0400 Subject: [PATCH] safety checks for return values of new helper method Signed-off-by: Lebbeous Fogle-Weekley --- Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm index a3836ef635..a06db2ba9b 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Holding.pm @@ -142,7 +142,7 @@ sub field_values { sub unit_titles { my ($self, $key) = @_; - if (exists $self->fields->{$key}) { + if (defined $self->fields->{$key}{UNIT_TITLES}) { # this dereferences and makes a new reference to make sure # the return value is a copy (not pointing to the object data) my @titles = @{$self->fields->{$key}{UNIT_TITLES}}; @@ -474,7 +474,7 @@ sub format { ($holding_start{$key}, $holding_end{$key}) = @{$self->field_values($key)}; ($holding_start{$key . '_title'}, $holding_end{$key . '_title'}) = - @{$self->unit_titles($key)}; + @{$self->unit_titles($key)} if $self->unit_titles($key); } if ($self->is_compressed) { -- 2.11.0