From 725915ef6b009645f58b4dfbd96956030a90e767 Mon Sep 17 00:00:00 2001
From: Jane Sandberg <js7389@princeton.edu>
Date: Wed, 3 May 2023 06:35:33 -0700
Subject: [PATCH] LP 1855781: get eg-help-popover working again

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
---
 .../eg2/src/app/share/eg-help-popover/eg-help-popover.component.ts    | 4 ++--
 Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html     | 2 +-
 .../circ_matrix_matchpoint/linked-circ-limit-sets.component.html      | 2 +-
 Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html        | 2 +-
 Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html         | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/share/eg-help-popover/eg-help-popover.component.ts b/Open-ILS/src/eg2/src/app/share/eg-help-popover/eg-help-popover.component.ts
index dce19a76b5..f02752c849 100644
--- a/Open-ILS/src/eg2/src/app/share/eg-help-popover/eg-help-popover.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/eg-help-popover/eg-help-popover.component.ts
@@ -18,10 +18,10 @@ export class EgHelpPopoverComponent {
 
     // placement value passed to ngbPopover that controls
     // where the popover is displayed. Values include
-    // 'auto', 'right', 'left', 'top-left', 'bottom-right',
+    // 'auto', 'start', 'end', 'top-start', 'bottom-end',
     // 'top', and so forth.
     @Input()
-    placement = '';
+    placement = 'auto';
 
     // Allow for overriding the default button class.
     // This augments the basic 'btn' class
diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
index e338e527f7..5926161ecd 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
@@ -36,7 +36,7 @@
       <div class="form-group row">
         <div class="col-lg-3">
           <label class="form-label" for="{{idPrefix}}-{{field.name}}">{{field.label}}</label>
-          <eg-help-popover [placement]="'right'" *ngIf="field.helpText" helpText="{{field.helpTextValue}}"></eg-help-popover>
+          <eg-help-popover placement="end" *ngIf="field.helpText" helpText="{{field.helpTextValue}}"></eg-help-popover>
           <ng-container *ngIf="isSafeToNull(field)">
             <br />(<a (click)="setToNull(field)" href='javascript:;'><span i18n>Unset</span></a>)
           </ng-container>
diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/linked-circ-limit-sets.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/linked-circ-limit-sets.component.html
index 04f46ec45e..76ad9139e9 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/linked-circ-limit-sets.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/linked-circ-limit-sets.component.html
@@ -64,7 +64,7 @@
                 (click)="addLinkedSet()"
                 i18n-title title="Add" i18n>Add
             </button>
-            <eg-help-popover i18n-helpText helpText="'Go to Local Admin -> Circulation Limit Sets to Create a Link Limit Set'" ></eg-help-popover>
+            <eg-help-popover i18n-helpText helpText="Go to Local Admin -> Circulation Limit Sets to Create a Link Limit Set" ></eg-help-popover>
         </div>
     </div>
 </div>
diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
index f53c638af5..0d37e2e041 100644
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.html
@@ -55,7 +55,7 @@
     </label>
     <eg-help-popover *ngIf="getFieldDoc(args.cls, args.field)"
       buttonClass="btn-sm text-info p-0 m-0"
-      [placement]="'right'" [helpText]="getFieldDoc(args.cls, args.field)">
+      placement="end" [helpText]="getFieldDoc(args.cls, args.field)">
     </eg-help-popover>
   </div>
 </ng-template>
diff --git a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
index e9737bc48c..26ceb76b83 100644
--- a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
@@ -7,7 +7,7 @@
   prefix=":) {{dynamicTitleText}}"
   suffix="Sandbox">
 </eg-title>
-<eg-help-popover [placement]="'right'" helpText="This page is for random ng stuff!"></eg-help-popover>
+<eg-help-popover [placement]="end" helpText="This page is for random ng stuff!"></eg-help-popover>
 <div class="row flex pt-2">
   <div i18n> Modify Page Title: </div>
   <div class="col-lg-2">
-- 
2.11.0