From 4c6adf05f1d6feafad478ddcfe140ec16a755014 Mon Sep 17 00:00:00 2001 From: Lebbeous Fogle-Weekley Date: Wed, 14 Nov 2012 14:50:46 -0500 Subject: [PATCH] When running methods for clients, send plain warnings to "real" logs Code inside an OpenSRF application method may use Perl libraries that warn and carp like most Perl code is wont to do. Instead of letting those message go to STDERR where they can be easily missed (and take up lots of disk space on application boxes), why not catch them and redirect them to our "real" logs using OpenSRF::Utils::Logger ? Deployment of this change would probably have the side effect of bringing to light bugs in applications (Evergreen) that will suddenly seem very noisy. Signed-off-by: Lebbeous Fogle-Weekley --- src/perl/lib/OpenSRF/Application.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/perl/lib/OpenSRF/Application.pm b/src/perl/lib/OpenSRF/Application.pm index 9283b7f..b4e2621 100644 --- a/src/perl/lib/OpenSRF/Application.pm +++ b/src/perl/lib/OpenSRF/Application.pm @@ -581,8 +581,16 @@ sub run { if (!$self->{remote}) { my $code = \&{$self->{package} . '::' . $self->{method}}; my $err = undef; + my $warnhandler; try { + $warnhandler = $SIG{__WARN__}; + $SIG{__WARN__} = sub { + (my $msg = shift) =~ s/\n$//; + $log->warn($self->{api_name} . ": $msg"); + return 1; # prevents warning going out to stderr + }; + $resp = $code->($self, $req, @params); } catch Error with { @@ -591,6 +599,8 @@ sub run { if( ref($self) eq 'HASH') { $log->error("Sub $$self{package}::$$self{method} DIED!!!\n\t$err\n", ERROR); } + } finally { + $SIG{__WARN__} = $warnhandler; }; if($err) { -- 2.11.0