From b4cc78f4a2ddcb64609602b062854f8783f7b31c Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Wed, 10 Sep 2014 21:36:29 -0400 Subject: [PATCH] "next" doesn't work if you're not in a for loop This was causing grievous "Internal server error" problems when people actually did enter their email address. More robust, more better. Yay. Signed-off-by: Dan Scott --- Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm index 60c998069f..1e03918fb2 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm @@ -419,9 +419,7 @@ sub load_login { $args->{barcode} = $username; } else { # do we need to append an email hostname? - if ($ou_email_host) { - # Assume they already passed in an email address - next if $username =~ m/\@/; + if ($ou_email_host and $username !~ m/\@/) { $username .= "\@$ou_email_host"; } $args->{username} = $username; -- 2.11.0