From 23175f28bd624c86f3dd1e42d149c61638f5bada Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Fri, 24 Jun 2011 10:44:43 -0400 Subject: [PATCH] Fix broken images for items without ISBNs in search results The search results code happily sets the src attribute of the cover image to an empty string (as returned by cleanISBN()) if currentISBN has not been defined (which is generally the case if an item doesn't have an ISBN, such as a DVD or a thesis or an old book). Protect against the empty string and set the src attribute to '/opac/images/blank.png' to avoid broken image indicators in search results. Signed-off-by: Dan Scott Signed-off-by: Dan Scott --- Open-ILS/web/opac/skin/default/js/result_common.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Open-ILS/web/opac/skin/default/js/result_common.js b/Open-ILS/web/opac/skin/default/js/result_common.js index dfd5455be5..1d25381c56 100644 --- a/Open-ILS/web/opac/skin/default/js/result_common.js +++ b/Open-ILS/web/opac/skin/default/js/result_common.js @@ -494,8 +494,12 @@ function resultDisplayRecord(rec, pos, is_mr) { } catch(e){ } */ - var pic = $n(r, config.names.result.item_jacket); - pic.setAttribute("src", buildISBNSrc(currentISBN)); + var pic = $n(r, config.names.result.item_jacket); + if (currentISBN) { + pic.setAttribute("src", buildISBNSrc(currentISBN)); + } else { + pic.setAttribute("src", "/opac/images/blank.png"); + } var title_link = $n(r, config.names.result.item_title); var author_link = $n(r, config.names.result.item_author); -- 2.11.0