From addd8b3fdc6d85cd086066c3e4ce752c84890a15 Mon Sep 17 00:00:00 2001
From: Kathy Lussier <klussier@masslnc.org>
Date: Mon, 15 Dec 2014 13:38:48 -0500
Subject: [PATCH] lp1350377 - Remove Transfer All Title Holds option from Bib
 Record

Removing the Transfer All Title Holds option from the bib record actions
menu in the xul and web clients. There were usability issues where the option
was accidentally selected as users were trying to transfer selected holds from
the View Holds portion of the bib record. There are also alternate, safer
means for accomplishing the same action.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---
 .../src/templates/staff/cat/catalog/t_catalog.tt2    |  2 --
 Open-ILS/xul/staff_client/chrome/content/cat/opac.js | 20 --------------------
 .../xul/staff_client/chrome/content/cat/opac.xul     |  1 -
 .../Circulation/remove-transfer-holds-option.txt     |  9 +++++++++
 4 files changed, 9 insertions(+), 23 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Circulation/remove-transfer-holds-option.txt

diff --git a/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2 b/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
index 47f1c6f183..00dc64e3df 100644
--- a/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
+++ b/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
@@ -25,8 +25,6 @@
             [% l('View Holds') %]</a></li>
         <li><a href dropdown-toggle ng-click="mark_hold_transfer_dest()">
             [% l('Mark as Title Hold Transfer Destination') %]</a></li>
-        <li><a href dropdown-toggle ng-click="transfer_holds_to_marked()">
-            [% l('Transfer All Title Holds') %]</a></li>
       </ul>
     </div>
   </div>
diff --git a/Open-ILS/xul/staff_client/chrome/content/cat/opac.js b/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
index 673eede35d..46da0b7c37 100644
--- a/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
+++ b/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
@@ -900,26 +900,6 @@ function mark_for_hold_transfer() {
     }
 }
 
-function transfer_title_holds() {
-    g.data.stash_retrieve();
-    var target = g.data.marked_record_for_hold_transfer;
-    if (!target) {
-        var m = $("offlineStrings").getString('staff.cat.opac.title_for_hold_transfer.destination_needed.label');
-        alert(m);
-        return;
-    }
-    var robj = g.network.simple_request('TRANSFER_TITLE_HOLDS',[ ses(), target, [ docid ] ]);
-    if (robj == 1) {
-        var m = $("offlineStrings").getString('staff.cat.opac.title_for_hold_transfer.success.label');
-        alert(m);
-    } else {
-        var m = $("offlineStrings").getString('staff.cat.opac.title_for_hold_transfer.failure.label');
-        alert(m);
-    }
-    hold_browser_reset = true;
-    if (g.view == 'hold_browser') { set_hold_browser(); };
-}
-
 function delete_record() {
     if (g.error.yns_alert(
         document.getElementById('offlineStrings').getFormattedString('cat.opac.delete_record.confirm', [docid]),
diff --git a/Open-ILS/xul/staff_client/chrome/content/cat/opac.xul b/Open-ILS/xul/staff_client/chrome/content/cat/opac.xul
index 3ed307175a..0a502c11ab 100644
--- a/Open-ILS/xul/staff_client/chrome/content/cat/opac.xul
+++ b/Open-ILS/xul/staff_client/chrome/content/cat/opac.xul
@@ -60,7 +60,6 @@
                 <menuseparator/>
                 <menuitem label="&staff.cat.copy_browser.holdings_maintenance.cmd_add_volumes.label;" accesskey="&staff.cat.copy_browser.holdings_maintenance.cmd_add_volumes.accesskey;" id="add_volumes" oncommand="add_volumes();"/>
                 <menuitem label="&staff.cat.opac.mark_for_hold_transfer.label;" accesskey="&staff.cat.opac.mark_for_hold_transfer.accesskey;" id="mark_for_hold_transfer" oncommand="mark_for_hold_transfer();"/>
-                <menuitem label="&staff.cat.opac.transfer_title_holds.label;" accesskey="&staff.cat.opac.transfer_title_holds.accesskey;" id="transfer_title_holds" oncommand="transfer_title_holds();"/>
                 <menuitem label="&staff.cat.opac.mark_for_multi_home.label;" accesskey="&staff.cat.opac.mark_for_multi_home.accesskey;" id="mark_for_multi_home" oncommand="mark_for_multi_home();"/>
                 <menuseparator/>
                 <menuitem label="&staff.cat.opac.bib_in_new_tab.label;" id="bib_in_new_tab" oncommand="bib_in_new_tab();"/>
diff --git a/docs/RELEASE_NOTES_NEXT/Circulation/remove-transfer-holds-option.txt b/docs/RELEASE_NOTES_NEXT/Circulation/remove-transfer-holds-option.txt
new file mode 100644
index 0000000000..21893d52aa
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Circulation/remove-transfer-holds-option.txt
@@ -0,0 +1,9 @@
+Removal of option to Transfer all title holds
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+Due to usability issues where the option could easily be clicked as
+users were trying to transfer selected holds, the option to _Transfer all
+title holds_ has been removed from the Actions menu available on the bib
+record. The option remains available in the Record Bucket interface. Staff can
+also perform the same action by viewing the holds on the bib record, selecting
+all rows, and then selecting _Transfer to Marked Title_ from the Actions
+for Selected Holds menu.
-- 
2.11.0