From 32770e5b6700fe04a96c71676ed2789e149e6181 Mon Sep 17 00:00:00 2001
From: Kathy Lussier <klussier@masslnc.org>
Date: Tue, 25 Jul 2017 15:45:21 -0400
Subject: [PATCH] LP#1706415: Address usability issues with bottom-of-page
 menus

Dropdown menus that appear at the bottom of the page in the web client had some
usability issues because their contents fell below the screen. This commit
adds a little space at the bottom of all web client pages and also makes
three bottom-of-the-page menus "drop up" instead of down. The three menus
are the stat-cat menus that appear at the bottom of the user registration
form, the Z39.50 actions menu, and the create reports template actions menu.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---
 Open-ILS/src/templates/staff/cat/z3950/t_list.tt2         | 3 ++-
 Open-ILS/src/templates/staff/circ/patron/t_edit.tt2       | 2 +-
 Open-ILS/src/templates/staff/css/style.css.tt2            | 3 +++
 Open-ILS/src/templates/staff/reporter/t_edit_template.tt2 | 1 +
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Open-ILS/src/templates/staff/cat/z3950/t_list.tt2 b/Open-ILS/src/templates/staff/cat/z3950/t_list.tt2
index e687c93f04..4ad211d0d7 100644
--- a/Open-ILS/src/templates/staff/cat/z3950/t_list.tt2
+++ b/Open-ILS/src/templates/staff/cat/z3950/t_list.tt2
@@ -88,7 +88,8 @@
   items-provider="z3950SearchGridProvider"
   grid-controls="gridControls"
   persist-key="cat.z3950_results"
-  dateformat="{{$root.egDateAndTimeFormat}}">
+  dateformat="{{$root.egDateAndTimeFormat}}"
+  class="dropup">
 
   <eg-grid-menu-item handler="showInCatalog" disabled="cant_showInCatalog"
     label="[% l('Show in Catalog') %]"></eg-grid-menu-item>
diff --git a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
index 76649b71f7..e17e38a569 100644
--- a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
+++ b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
@@ -860,7 +860,7 @@ within the "form" by name for validation.
     </div>
     <div class="col-md-3 reg-field-input">
       <div ng-if="cat.entries().length != 0">
-        <div class="btn-group" uib-dropdown>
+        <div class="btn-group dropup" uib-dropdown>
           <button type="button" class="btn btn-default" ng-class="{'ng-invalid': cat.required() == 1 && !stat_cat_entry_maps[cat.id()] }" uib-dropdown-toggle>
             <span style="padding-right: 5px;">
               {{stat_cat_entry_maps[cat.id()]}}</span>
diff --git a/Open-ILS/src/templates/staff/css/style.css.tt2 b/Open-ILS/src/templates/staff/css/style.css.tt2
index 9aa3eda411..f7abf8409b 100644
--- a/Open-ILS/src/templates/staff/css/style.css.tt2
+++ b/Open-ILS/src/templates/staff/css/style.css.tt2
@@ -1,3 +1,6 @@
+/* Create some padding at bottom of the page for breathing room */
+body { padding-bottom: 50px; }
+
 /* --------------------------------------------------------------------------
  * Simple default navbar style adjustements to apply the Evergreen color.
  * TODO: style other components to match EG color scheme
diff --git a/Open-ILS/src/templates/staff/reporter/t_edit_template.tt2 b/Open-ILS/src/templates/staff/reporter/t_edit_template.tt2
index fbb266d3a0..62460efb6e 100644
--- a/Open-ILS/src/templates/staff/reporter/t_edit_template.tt2
+++ b/Open-ILS/src/templates/staff/reporter/t_edit_template.tt2
@@ -135,6 +135,7 @@
             features="-sort,-multisort,-multiselect"
             items-provider="grid_display_fields_provider"
             grid-controls="display_grid_controls"
+            class="dropup"
           >
             <eg-grid-action 
               handler="changeDisplayLabel"
-- 
2.11.0