From db26b04781c363ff6fc5133ec173f5a44d043a9a Mon Sep 17 00:00:00 2001 From: edoceo Date: Wed, 6 Feb 2013 20:06:37 -0800 Subject: [PATCH] Clean up the Dumper and the commented out notes Signed-off-by: edoceo Signed-off-by: Michael Peters --- .../src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm | 18 +++--------------- .../src/templates/opac/parts/record/copy_table.tt2 | 2 -- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm index 0934444657..d655b7092e 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm @@ -1,6 +1,5 @@ package OpenILS::WWW::EGCatLoader; use strict; use warnings; -use Data::Dumper; use Apache2::Const -compile => qw(OK DECLINED FORBIDDEN HTTP_INTERNAL_SERVER_ERROR REDIRECT HTTP_BAD_REQUEST); use OpenSRF::Utils::Logger qw/$logger/; use OpenILS::Utils::CStoreEditor qw/:funcs/; @@ -79,10 +78,11 @@ sub load_record { $ctx->{marc_xml} = $rec_data[0]->{marc_xml}; $ctx->{copies} = $copy_rec->gather(1); - # Add Copy Notes some how to Each Copy? + + # Add Copy Notes to Each Copy? foreach my $copy (@{$ctx->{copies}}) { $copy->{notes} = $U->simplereq( - 'open-ils.circ', + 'open-ils.circ', 'open-ils.circ.copy_note.retrieve.all', {itemid => $copy->{id}, pub => 1 } ); @@ -201,18 +201,6 @@ sub mk_copy_query { $rec_id, undef, undef, $copy_limit, $copy_offset, $self->ctx->{is_staff} ); - # Add Copy Notes? - # Some How need to Make Notes an Array of Notes - # This makes two rows for the record, when there are two copy notes - cause of the JOIN - # Also, if this is moved to around line 68 as $copy_rec it seems to not work the same? -# $query->{select}->{acpn} = [ -# {column => 'title', alias => 'note_title'}, -# {column => 'value', alias => 'note_value'} -# ]; -# $query->{from}->{acp}->{acpn} = { -# type => 'left' -# }; - if($org != $self->ctx->{aou_tree}->()->id) { # no need to add the org join filter if we're not actually filtering $query->{from}->{acp}->{aou} = { diff --git a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 index 7ea80979b6..02ca127b16 100644 --- a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 +++ b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 @@ -1,7 +1,5 @@ [%- -USE Dumper; - # If being used in serial mode, flatten list of units so that they can be # used like one long list of copies without changing so much code below. IF serial_holdings; -- 2.11.0