From 37b310902bdad95a61d6905af0d5e04e985352b2 Mon Sep 17 00:00:00 2001 From: Lebbeous Fogle-Weekley Date: Mon, 8 Aug 2011 13:22:05 -0400 Subject: [PATCH] In a middle-layer method for returning holdable formats on a metarecord, Do a better test of copy holdability than we were doing previously. We can't do a perfect test: we don't really know what patron we're doing this for, and even if we did, from here it's nontrivial to figure out whether we're doing indb holds or script-based, much less run the tests. Still, we can test whether a copy's in a holdable status, a holdable location, and is itself not explicitly marked unholdable. Signed-off-by: Lebbeous Fogle-Weekley --- .../perlmods/OpenILS/Application/Search/Biblio.pm | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm index e12ccb141f..05c5d4d8eb 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm @@ -2416,6 +2416,40 @@ sub rec_to_mr_rec_descriptors { my $desc = $e->search_metabib_record_descriptor($search); + my $query = { + distinct => 1, + select => { 'bre' => ['id'] }, + from => { + 'bre' => { + 'acn' => { + 'join' => { + 'acp' => {"join" => {"acpl" => {}, "ccs" => {}}} + } + } + } + }, + where => { + '+bre' => { id => \@recs }, + '+acp' => { + holdable => 't', + deleted => 'f' + }, + "+ccs" => { holdable => 't' }, + "+acpl" => { holdable => 't' } + } + }; + + my $good_records = $e->json_query($query) or return $e->die_event; + + my @keep; + for my $d (@$desc) { + if ( grep { $d->record == $_->{id} } @$good_records ) { + push @keep, $d; + } + } + + $desc = \@keep; + return { metarecord => $mrec, descriptors => $desc }; } -- 2.11.0